Add scroll to active toc #2932
Merged
Add scroll to active toc #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is great - I was wondering if you might like to improve the sidebar in "book" views as well - see https://docs.scala-lang.org/scala3/book/packaging-imports.html |
|
@bishabosha |
|
Thanks @IZUMIRU , I love it :) just asking for others opinions |
adpi2
approved these changes
Nov 28, 2023
|
@bishabosha @adpi2 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the toc is long, you may not know where you are reading when you read the chapter below.
I think there is a matter of preference regarding UX, so I will leave it to you to decide whether to merge or close:)
Nov-28-2023.02-36-38.mp4